Default_rtp_range_min

brave · September 23, 2024, 2:13pm

Hi guys!

We are trying to use remote publishers and have a question about this:

meetecho/janus-gateway/blob/master/src/plugins/janus_videoroom.c#L2503


      
          	janus_videoroom_publisher_stream *ps,
          	const gchar *host, int port, int rtcp_port, int pt, uint32_t ssrc,
          	gboolean simulcast, int srtp_suite, const char *srtp_crypto,
          	int substream, gboolean is_video, gboolean is_data);
          static void janus_videoroom_rtp_forwarder_rtcp_receive(janus_rtp_forwarder *rf, char *buffer, int len);
          static json_t *janus_videoroom_rtp_forwarder_summary(janus_rtp_forwarder *f);
          static void janus_videoroom_create_dummy_publisher(janus_videoroom *room, GHashTable *streams);
          
          /* We support remote publishers as well, for which we use plain RTP,
           * which means we need to create and work with generic file descriptors */
          #define DEFAULT_RTP_RANGE_MIN 10000
          #define DEFAULT_RTP_RANGE_MAX 60000
          static uint16_t rtp_range_min = DEFAULT_RTP_RANGE_MIN;
          static uint16_t rtp_range_max = DEFAULT_RTP_RANGE_MAX;
          static uint16_t rtp_range_slider = DEFAULT_RTP_RANGE_MIN;
          static janus_mutex fd_mutex = JANUS_MUTEX_INITIALIZER;
          #define REMOTE_PUBLISHER_BASE_SSRC	1000
          #define REMOTE_PUBLISHER_SSRC_STEP	10
          /* Helpers to create a listener filedescriptor */
          static int janus_videoroom_create_fd(int port, in_addr_t mcast, const janus_network_address *iface, char *host, size_t hostlen);
          /* Helper to return fd port */

Any reason it’s hardcoded here, and if no, can we propose PR to get this range from config?

lorenzo · September 23, 2024, 4:14pm

A PR is always welcome. I’d suggest making it similar to the configs other plugins have for the same functionality.

Topic		Replies	Views
SRTP for remote publishers in video rooms General	4	85	May 15, 2024
Videoroom subscribers and simulcast relay General	11	72	September 30, 2024
Network quality data in Janus General	10	112	January 26, 2024
REMB not working in janus General	1	81	December 21, 2023
RTP Forwarding Live room to Streaming plugin with simulcasting General	6	46	September 17, 2024

Default_rtp_range_min

Related Topics