Hi, we are facing a problem with recording in videoroom.
We encountered what record of remote publisher streams writes empty files if remote publisher added after record is started. If remote publisher joined before starting of the record all is fine.
I found out what on add_remote_publisher/update_remote_publisher recorders were not created.
Trying to fix recording · meetecho/janus-gateway@b885fae · GitHub this one fixes the problem, If this is ok, I’ll create pr to master.
I think the patch looks fine, as it basically replicates what janus_videoroom_setup_media does for regular publishers (and that remote publishers don’t go through since there’s no local WebRTC PeerConnection that goes active). I don’t understand why you added the same to the update_remote_publisher request, though: if you’re updating a remote publisher, it means they’re in already, and so if recording was enabled after they were first added they’re already being recorded.
on update_remote_publisher new streams can be added. We tested without it first and new streams were not recorded
1 Like