Reclaim_session_timeout issue

General
1

Hi everyone,

Per doc, reclaim_session_timeout is ‘how long (in seconds) we should wait for a
janus session to be reclaimed after the transport is gone’.

In real, this timeout is counted from session last activity (like session_timeout).

janus.c

if((timeout > 0 && (now - session->last_activity >= timeout * G_USEC_PER_SEC)) ||      ((g_atomic_int_get(&session->transport_gone) && now - session->last_activity >= (gint64)reclaim_session_timeout * G_USEC_PER_SEC))) {...}

In some configurations, this leads to a premature session closure.

Example:
Proxy - nginx, transport - websocket.
session_timeout = 90;
reclaim_session_timeout = 30;

Nginx closes websocket connection 60s after session last activity (default behavior).
Session_timeout (90) not reached yet.
Janus immediately closes session because (now - last_activity) > reclaim_session_timeout (30).
Remote device is trying to restore the connection but can’t reclaim session.
As result, the call is terminated.

2

The session timeout is not considered anymore once the session is gone. If reclaim timeout isn’t configured, for instance, a WebSocket connection going down will close all sessions immediately, independently of whether or not a session timeout was reached, as we know that user is no longer there. So the 90 is irrelevant in this example. But I do get your point on last activity being incorrect as a starting point for reclaims, as in that case the “transport gone time” should be the starting point instead. I’ll see if this can be fixed easily or not.

1 Like
3

Thank you for your quick response.

4

@oleksandr.mihal I just created a PR that should address the issue. I haven’t tested it yet, though. Please make a few tests and let me know if it is indeed fixing the issue for you. For any feedback please add textto the PR and not here, so that we can track the progression on Github.