Janus build fails when using latest version of libsrtp (2.6.0)

General
1

When building janus using the latest libsrtp version 2.6.0, the build fails

plugins/janus_sip.c:7541:13: error: too few arguments to function ‘srtp_protect_rtcp’
 7541 |   int res = srtp_protect_rtcp(session->media.video_srtp_out, &sbuf, &protected);
      |             ^~~~~~~~~~~~~~~~~
In file included from plugins/../rtpsrtp.h:17,
                 from plugins/janus_sip.c:691:
/usr/include/srtp2/srtp.h:1149:19: note: declared here
 1149 | srtp_err_status_t srtp_protect_rtcp(srtp_t ctx,
      |                   ^~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:2207: plugins/libjanus_sip_la-janus_sip.lo] Error 1

I know the guideline is to use libsrtp v2.2.0, but are there any plans to upgrade to the latest version of libsrtp?

2

We are aware that the most recent libsrtp iterations have changed some APIs.
Didn’t try myself v2.6.0, however I’m pretty sure that v2.5.0 is fully compatible.

3

@turtle are you sure you didn’t try the libsrtp master, rather than the 2.6.0 release? The changelog for 2.6.0 doesn’t mention any of the signature changes we saw in master, which makes me think those are not in there yet.

1 Like
4

@lorenzo, I indeed mistakenly built libsrtp master instead of v2.6.0. I can confirm that v2.6.0 works fine.

2 Likes